Zha0q1 commented on a change in pull request #15580: update profiler tutorial
URL: https://github.com/apache/incubator-mxnet/pull/15580#discussion_r305599943
 
 

 ##########
 File path: docs/tutorials/python/profiler.md
 ##########
 @@ -193,10 +193,10 @@ print(profiler.dumps())
 You can also dump the information collected by the profiler into a `json` file 
using the `profiler.dump()` function and view it in a browser.
 
 ```python
-profiler.dump()
+profiler.dump(finished=False)
 
 Review comment:
   Actually, another solution is to create a new tutorial (`.md` file) for the 
next section (profiling custom operator section). This way, we have a brand new 
profiler 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to