gordonklaus commented on issue #573: Move SPI and I2C config definitions from BSPs to MCUs. URL: https://github.com/apache/mynewt-core/pull/573#issuecomment-332208840 @andrzej-kaczmarek That's correct. I was a bit uncertain about where this should be defined. You are right, it makes sense that it should be defined by the package that uses it. I will move the definition of SPI_0_MASTER_SS_PIN into sx1276. I will also rename it to LORA_SPI_CS_PIN (the SX1276 datasheet refers to it as Chip Select). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
With regards, Apache Git Services
