wes3 commented on issue #573: Move SPI and I2C config definitions from BSPs to MCUs. URL: https://github.com/apache/mynewt-core/pull/573#issuecomment-332234556 Gordon: based on the conversation you had with andrzej, I think the CS_PIN definition belongs in hw/drivers/lora/sx1276/syscfg.yml. I had thought you had moved it there but I did not see it in the commits (might have missed it). Overriding it in the BSP makes sense to me, or we can leave it to the target, but I think it fine if their is an override for it in the BSP. It can always be overridden in the target for folks who want to change the pin. As a minor nit, I think renaming this to be SX1276_CS_PIN might be a bit better as this chip could be used for non-lora purposes. Fine by me if you do not want to change the name. Well, I guess I would only do this if that definition is agreed to be moved into the sx1276 dir. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
With regards, Apache Git Services
