rymanluk commented on a change in pull request #583: Mesh fixes and improvements
URL: https://github.com/apache/mynewt-core/pull/583#discussion_r141585289
##########
File path: net/nimble/host/mesh/src/health.c
##########
@@ -99,6 +99,7 @@ static size_t health_get_current(struct bt_mesh_model *mod,
fault_count = 0;
} else {
sys_put_le16(company_id, company_ptr);
+ net_buf_simple_add(msg, fault_count);
Review comment:
Could you please extend commit msg by explanation why we need that?
if i undertstand it correctly fault_get_cur() gives application a pointer to
buffer where faults are written. If it succeed we need to update our os_mbuf
with with len of faults array written by application.
By the way, hope application does not exceed maximum faults array size.
Maybe it would be better to have os_mbuf (net_buf) in the callback instead
of *u8_t?
@jhedberg ^^
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
