rymanluk commented on a change in pull request #583: Mesh fixes and improvements
URL: https://github.com/apache/mynewt-core/pull/583#discussion_r141593137
##########
File path: net/nimble/host/mesh/src/health.c
##########
@@ -99,6 +99,7 @@ static size_t health_get_current(struct bt_mesh_model *mod,
fault_count = 0;
} else {
sys_put_le16(company_id, company_ptr);
+ net_buf_simple_add(msg, fault_count);
Review comment:
Ah I see that &fault_count in the callback contains maximum bytes which can
be written to the buffer but still, worth to consider passing os_mbuf in the
callback.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
