sjanc commented on a change in pull request #753: npl/riot: Improve timer glue 
code
URL: https://github.com/apache/mynewt-nimble/pull/753#discussion_r377597180
 
 

 ##########
 File path: porting/npl/riot/include/nimble/nimble_npl_os.h
 ##########
 @@ -215,7 +215,7 @@ ble_npl_callout_is_active(struct ble_npl_callout *c)
 static inline ble_npl_time_t
 ble_npl_callout_get_ticks(struct ble_npl_callout *co)
 {
-    return co->target_ticks;
+    return (ble_npl_time_t)co->target_ticks;
 
 Review comment:
   this looks a bit odd,  shouldn't ble_npl_time_t in riot port be change to 
uint64_t ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to