bergzand commented on a change in pull request #753: npl/riot: Improve timer
glue code
URL: https://github.com/apache/mynewt-nimble/pull/753#discussion_r378768599
##########
File path: porting/npl/riot/include/nimble/nimble_npl_os.h
##########
@@ -100,7 +100,8 @@ ble_npl_eventq_get(struct ble_npl_eventq *evq,
ble_npl_time_t tmo)
} else if (tmo == BLE_NPL_TIME_FOREVER) {
return (struct ble_npl_event *)event_wait(&evq->q);
} else {
- return (struct ble_npl_event *)event_wait_timeout(&evq->q, (tmo *
1000));
+ return (struct ble_npl_event *)event_wait_timeout(&evq->q,
+ (tmo * US_PER_MS));
Review comment:
I have to admit that I intentionally ignored the edge case here, as you
mention, there is no easy way to solve the edge case here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
