[GitHub] [mynewt-core] gonccalo edited a comment on issue #2227: fix incorrect check in lis2ds12_set_full_scale

[GitBox]

gonccalo edited a comment on issue #2227: fix incorrect check in 
lis2ds12_set_full_scale
URL: https://github.com/apache/mynewt-core/pull/2227#issuecomment-595345794
 
 
   I also found some problems in the `lis2ds12_set_rate` function.
   The `LIS2DS12_DATA_RATE_LP_10BIT_800HZ` is defined as 0x70 when it should be 
0xF0 according to the documentation. The condition check for the rate argument 
is also not the best one (and is incorrect right now).
   ![Screenshot from 2020-03-05 
17-14-04](https://user-images.githubusercontent.com/5223817/76006785-e71a7480-5f04-11ea-90ae-c031f14f9ef0.png)
   
   Should I open a new pull request or can I make these changes here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services