apache-mynewt-bot commented on issue #2227: fix incorrect check in lis2ds12_set_full_scale URL: https://github.com/apache/mynewt-core/pull/2227#issuecomment-595390925 <!-- style-bot --> ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md) #### hw/drivers/sensors/lis2ds12/src/lis2ds12.c <details> ```diff @@ -584,7 +584,7 @@ int rc; uint8_t reg; - // TODO probably not the best check for me + /* TODO probably not the best check for me */ if (0 != (rate & ~(LIS2DS12_CTRL_REG1_ODR | LIS2DS12_CTRL_REG1_HF_ODR))) { LIS2DS12_LOG_ERROR("Invalid rate value\n"); rc = SYS_EINVAL; ``` </details>
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services