prasad-alatkar commented on a change in pull request #790: nimble/store: Fix
nimble store behavior when CCCDs exceed static defined limit
URL: https://github.com/apache/mynewt-nimble/pull/790#discussion_r403840472
##########
File path: nimble/host/src/ble_store_util.c
##########
@@ -230,16 +315,43 @@ ble_store_util_delete_oldest_peer(void)
int
ble_store_util_status_rr(struct ble_store_status_event *event, void *arg)
{
+ int rc = BLE_HS_EUNKNOWN;
+ ble_addr_t peer_id_addr;
+ int num_peers;
+
switch (event->event_code) {
case BLE_STORE_EVENT_OVERFLOW:
switch (event->overflow.obj_type) {
- case BLE_STORE_OBJ_TYPE_OUR_SEC:
- case BLE_STORE_OBJ_TYPE_PEER_SEC:
- case BLE_STORE_OBJ_TYPE_CCCD:
- return ble_gap_unpair_oldest_peer();
-
- default:
- return BLE_HS_EUNKNOWN;
+ case BLE_STORE_OBJ_TYPE_OUR_SEC:
+ case BLE_STORE_OBJ_TYPE_PEER_SEC:
+ return ble_gap_unpair_oldest_peer();
+ case BLE_STORE_OBJ_TYPE_CCCD:
+ if ((rc = ble_gap_unpair_oldest_peer()) == BLE_HS_ENOENT) {
Review comment:
@rymanluk That is what I have done actually in
`ble_store_util_subscribed_cccds` !! What I think is
`ble_gap_unpair_oldest_peer` is not anyway going to unpair current peer (the
one for which we want to make space), so introducing similar function with
`ble_addr_t` as input won't be really that helpful. Please let me know your
thoughts on this.
The issue I believe is only confined to CCCDs, so
`ble_gap_unpair_oldest_peer()) == BLE_HS_ENOENT` will make sure that we do not
have any bonded devices and still we are out of storage space, which can be
used to conclude that we need to clean old CCCDs (except the current one).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
