vrahane commented on code in PR #3168: URL: https://github.com/apache/mynewt-core/pull/3168#discussion_r1643099478
########## sys/log/full/include/log/log.h: ########## @@ -97,6 +97,7 @@ typedef int (*lh_append_mbuf_body_func_t)(struct log *log, typedef int (*lh_walk_func_t)(struct log *, log_walk_func_t walk_func, struct log_offset *log_offset); typedef int (*lh_flush_func_t)(struct log *); +typedef uint16_t (*lh_read_entry_len_func_t)(struct log *, const void *dptr); Review Comment: It's consistent with the other prototypes. That's the reason I made it that way. For function pointers it does not matter what the name of the variable is anyways. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org