kasjer commented on code in PR #3168:
URL: https://github.com/apache/mynewt-core/pull/3168#discussion_r1669155560
##########
sys/log/full/include/log/log.h:
##########
@@ -97,6 +97,7 @@ typedef int (*lh_append_mbuf_body_func_t)(struct log *log,
typedef int (*lh_walk_func_t)(struct log *,
log_walk_func_t walk_func, struct log_offset *log_offset);
typedef int (*lh_flush_func_t)(struct log *);
+typedef uint16_t (*lh_read_entry_len_func_t)(struct log *, const void *dptr);
Review Comment:
I leave it up to you. If you do, I will click `Resolve conversation` button
so others can focus on other things. I looked at the code and tested this
change and I don't see any improvement. Combability is not preserved and with
the way TLV is done it will not be better in the future if more changes are
needed. I can't approve this. Even if you fix all small things I pointed out I
can't see any reason to add this new field let alone the way it is added. If
you find someone else willing to approve so be it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
