[ 
https://issues.apache.org/jira/browse/NIFI-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14699012#comment-14699012
 ] 

Joseph Witt commented on NIFI-790:
----------------------------------

Bryan,

In reviewing the patch I can see inconsistent formatting/use of tabs.

I see this in one of the poms
+                <groupId>org.glassfish.jersey.core</groupId>
+                <artifactId>jersey-client</artifactId>
+                <version>2.19</version>

But do not see any associated LICENSE or NOTICE updates.

Same for these:
+        <dependency>
+            <groupId>org.glassfish</groupId>
+            <artifactId>javax.json</artifactId>
+            <version>1.0.4</version>
+        </dependency>
+        <dependency>
+            <groupId>javax.json</groupId>
+            <artifactId>javax.json-api</artifactId>
+            <version>1.0</version>
+        </dependency>

I would definitely expect to see changes to LICENSE/NOTICE file(s) as needed.  
Perhaps that isn't necessary here but just based on the deps mentioned above 
I'd expect something.

Is it really the case that we don't need a dependency on any ambari client jar? 
 Is it just a ganglia based collector?

Thanks
Joe

> Create reporting task to deliver metrics to Apache Ambari
> ---------------------------------------------------------
>
>                 Key: NIFI-790
>                 URL: https://issues.apache.org/jira/browse/NIFI-790
>             Project: Apache NiFi
>          Issue Type: New Feature
>          Components: Extensions
>            Reporter: Joseph Witt
>            Assignee: Bryan Bende
>             Fix For: 0.3.0
>
>         Attachments: NIFI-790.patch
>
>
> Apache Ambari seems to be a good place to aggregate metrics and we're hearing 
> from folks that want to use it.
> We should provide a reporting task that makes it extremely simple to send to 
> Apache Ambari.
> Probably best to do a simple first pass of basic metrics off high-level flow 
> summary stuff.  So we can use that to get more detailed feedback on where to 
> go with it next.  Ambari seems to have a REST API to deliver to.
> https://ambari.apache.org/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to