[ 
https://issues.apache.org/jira/browse/NIFI-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15151037#comment-15151037
 ] 

Sean Busbey commented on NIFI-1520:
-----------------------------------

Having the war binary different from the source jar is a little trickier. 
Avro's tool fat jar is the best example I have to point to. It makes use of the 
fact that ASF policy allows either {{LICENSE}} or {{LICENSE.txt}}.

Avro manually maintains in that particular module's 
{{src/main/resources/META-INF}} a LICENSE and NOTICE for the binary artifact as 
well as LICENSE.txt and NOTICE.txt for the source artifact. (these could 
similarly be automatically aggregated and placed in the resources output area.)

Make sure the source artifact doesn't get the binary version of the L/N files:
{code}
        <plugin>
          <groupId>org.apache.maven.plugins</groupId>
          <artifactId>maven-source-plugin</artifactId>
          <configuration>
            <excludes>
              <exclude>META-INF/LICENSE</exclude>
              <exclude>META-INF/NOTICE</exclude>
              <exclude>META-INF/*.text</exclude>
            </excludes>
          </configuration>
        </plugin>
{code}

The avro binary jar is made using the shade plugin, so it excludes all 
LICENSE.txt and NOTICE.txt files to avoid the source licensing files. In the 
case of NiFi's wars, I think we can use [the overlay plugin 
configuration|https://maven.apache.org/plugins/maven-war-plugin/war-mojo.html#overlays]
 to exclude {{META-INF/*.txt}}.

> Evaluate/Fix LICENSE/NOTICE entries on Javadoc/Sources bundles
> --------------------------------------------------------------
>
>                 Key: NIFI-1520
>                 URL: https://issues.apache.org/jira/browse/NIFI-1520
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Tools and Build
>    Affects Versions: 0.5.0
>            Reporter: Joseph Witt
>
> Sean Busbey NiFi 0.5.0 RC3 finding:
> ---
> * several -source and -javadoc jars contain improper LICENSE/NOTICE files
> (they cover things "in the binary artifact" that are not in the artifact
> containing the LICENSE/NOTICE file)
> ex:
> * -source and -javadoc for war packaging
> * -source for nar packaging
> --



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to