[ 
https://issues.apache.org/jira/browse/NIFI-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15201468#comment-15201468
 ] 

Joseph Witt commented on NIFI-1647:
-----------------------------------

reviewing

> Spring context processor improvements
> -------------------------------------
>
>                 Key: NIFI-1647
>                 URL: https://issues.apache.org/jira/browse/NIFI-1647
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Joseph Witt
>            Assignee: Oleg Zhurakousky
>            Priority: Minor
>             Fix For: 0.6.0
>
>
> Here are a couple observations/things to improve on the Spring processors 
> included in 0.6.0.
> 1) The validators for the classpath and context properties should not be 
> validating eachother.  When compound validation is needed that is the job of 
> customValidate.  They should each have simple validators like checking for a 
> directory in the case of the path and checking not empty in the case of the 
> context.  Then, customValidate should run the logic currently held in 
> SpringContextValidator.  Doing this will eliminate the two warnings that come 
> out now whenever one of them isn't right.
> 2) It seems really unclear how one can add new spring context xmls.  Is it at 
> startup only?  When adding the processor only?  I've tried putting a new one 
> in the path directory and putting one in the conf directory but still it 
> doesn't seem to find it.  It appears some code cleanup/clarity is needed but 
> at very least we should document what the user should expect/do to load new 
> context configs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to