[
https://issues.apache.org/jira/browse/NIFI-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15201467#comment-15201467
]
ASF GitHub Bot commented on NIFI-1647:
--------------------------------------
GitHub user olegz opened a pull request:
https://github.com/apache/nifi/pull/288
NIFI-1647 fixed validators and config resolution
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/olegz/nifi NIFI-1647
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/288.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #288
----
commit ebc2cf68aaaf7df4d5350c0dbfaa9b77a4c3a327
Author: Oleg Zhurakousky <o...@suitcase.io>
Date: 2016-03-18T13:26:54Z
NIFI-1647 fixed validators and config resolution
----
> Spring context processor improvements
> -------------------------------------
>
> Key: NIFI-1647
> URL: https://issues.apache.org/jira/browse/NIFI-1647
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Joseph Witt
> Assignee: Oleg Zhurakousky
> Priority: Minor
> Fix For: 0.6.0
>
>
> Here are a couple observations/things to improve on the Spring processors
> included in 0.6.0.
> 1) The validators for the classpath and context properties should not be
> validating eachother. When compound validation is needed that is the job of
> customValidate. They should each have simple validators like checking for a
> directory in the case of the path and checking not empty in the case of the
> context. Then, customValidate should run the logic currently held in
> SpringContextValidator. Doing this will eliminate the two warnings that come
> out now whenever one of them isn't right.
> 2) It seems really unclear how one can add new spring context xmls. Is it at
> startup only? When adding the processor only? I've tried putting a new one
> in the path directory and putting one in the conf directory but still it
> doesn't seem to find it. It appears some code cleanup/clarity is needed but
> at very least we should document what the user should expect/do to load new
> context configs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
