[ 
https://issues.apache.org/jira/browse/NIFI-1118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15201954#comment-15201954
 ] 

Joe Skora commented on NIFI-1118:
---------------------------------

@joewitt, I think we have to agree to disagree on this one, which is fine.

Based on this conversation today, *I think we should push 0.6.0 to release 
without this and work out details next week*.

No matter how we resolve 
[NIFI-1118|https://issues.apache.org/jira/browse/NIFI-1118], I still have 
concerns about [NIFI-1649|https://issues.apache.org/jira/browse/NIFI-1649]:
1. *fixing the bug will be a "behavior changing" impact* to anyone relying on 
the buggy behavior, 
2. there is some ambiguity regarding what the "correct" behavior would be for 
the current version, 
3. if flow files have lines long enough to cause concerns about buffering, *I 
fear the existing SplitText is either not handling such long lines correctly or 
the underlying InputStream must be putting the content on the heap anyway* 
because I don't believe mark()/reset() can handle arbitrarily long lines.

Thanks for working through this with us.  Let's get 0.6.0 out and move forward!

> Enable SplitText processor to limit line length and filter header lines
> -----------------------------------------------------------------------
>
>                 Key: NIFI-1118
>                 URL: https://issues.apache.org/jira/browse/NIFI-1118
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: Mark Bean
>            Assignee: Joe Skora
>             Fix For: 0.6.0
>
>
> Include the following functionality to the SplitText processor:
> 1) Maximum size limit of the split file(s)
> A new split file will be created if the next line to be added to the current 
> split file exceeds a user-defined maximum file size
> 2) Header line marker
> User-defined character(s) can be used to identify the header line(s) of the 
> data file rather than a predetermined number of lines
> These changes are additions, not a replacement of any property or behavior. 
> In the case of header line marker, the existing property "Header Line Count" 
> must be zero for the new property and behavior to be used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to