[ 
https://issues.apache.org/jira/browse/NIFI-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15296674#comment-15296674
 ] 

ASF GitHub Bot commented on NIFI-1913:
--------------------------------------

GitHub user JPercivall opened a pull request:

    https://github.com/apache/nifi/pull/462

    NIFI-1913 Properly removing flowfile in HandleHttpRequest when the Co…

    …ntext Map fails to register the request

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/JPercivall/nifi NIFI-1913

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/462.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #462
    
----
commit 44013976749d377706999fc49a1a4d3014909a69
Author: jpercivall <joeperciv...@yahoo.com>
Date:   2016-05-23T16:24:43Z

    NIFI-1913 Properly removing flowfile in HandleHttpRequest when the Context 
Map fails to register the request

----


> HandleHttpRequest doesn't correctly handle failures to register requests
> ------------------------------------------------------------------------
>
>                 Key: NIFI-1913
>                 URL: https://issues.apache.org/jira/browse/NIFI-1913
>             Project: Apache NiFi
>          Issue Type: Bug
>            Reporter: Joseph Percivall
>            Assignee: Joseph Percivall
>
> While looking at this[1] stack overflow question I came across the fact that 
> HandleHttpRequest doesn't properly handle the flowfiles when there is a 
> failure to register[2]. The created FlowFile should be removed just like it 
> is done here[3]. This lack of removal causes a FlowFileHandlingException to 
> occur when the context map fails to register the flowfile.
> The fix is simply adding "session.remove(flowFile);" to the "if 
> (!registered)" block.
> [1] 
> http://stackoverflow.com/questions/37394219/nifi-transfer-relationship-not-specified
>  
> [2] 
> https://github.com/apache/nifi/blob/9064b976317e316f42ac279dd026105b54a17ddb/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/HandleHttpRequest.java#L601-L601
> [3] 
> https://github.com/apache/nifi/blob/9064b976317e316f42ac279dd026105b54a17ddb/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/HandleHttpRequest.java#L489-L489



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to