[
https://issues.apache.org/jira/browse/NIFI-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15296856#comment-15296856
]
ASF GitHub Bot commented on NIFI-1913:
--------------------------------------
Github user pvillard31 commented on the pull request:
https://github.com/apache/nifi/pull/462#issuecomment-221058590
There is a double space on line 160 in test class. Travis seems not to be
run on 0.x branch so I don't know if contrib check would fail because of that
(cannot personally check right now).
Otherwise, +1.
> HandleHttpRequest doesn't correctly handle failures to register requests
> ------------------------------------------------------------------------
>
> Key: NIFI-1913
> URL: https://issues.apache.org/jira/browse/NIFI-1913
> Project: Apache NiFi
> Issue Type: Bug
> Reporter: Joseph Percivall
> Assignee: Joseph Percivall
>
> While looking at this[1] stack overflow question I came across the fact that
> HandleHttpRequest doesn't properly handle the flowfiles when there is a
> failure to register[2]. The created FlowFile should be removed just like it
> is done here[3]. This lack of removal causes a FlowFileHandlingException to
> occur when the context map fails to register the flowfile.
> The fix is simply adding "session.remove(flowFile);" to the "if
> (!registered)" block.
> [1]
> http://stackoverflow.com/questions/37394219/nifi-transfer-relationship-not-specified
>
> [2]
> https://github.com/apache/nifi/blob/9064b976317e316f42ac279dd026105b54a17ddb/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/HandleHttpRequest.java#L601-L601
> [3]
> https://github.com/apache/nifi/blob/9064b976317e316f42ac279dd026105b54a17ddb/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/HandleHttpRequest.java#L489-L489
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
