[ https://issues.apache.org/jira/browse/MINIFI-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993175#comment-15993175 ]
ASF GitHub Bot commented on MINIFI-275: --------------------------------------- Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/85#discussion_r114138730 --- Diff: libminifi/include/core/yaml/YamlConfiguration.h --- @@ -88,10 +102,17 @@ class YamlConfiguration : public FlowConfiguration { void parseRemoteProcessGroupYaml(YAML::Node *node, core::ProcessGroup * parent); // Process Provenance Report YAML - void parseProvenanceReportingYaml(YAML::Node *reportNode, core::ProcessGroup * parentGroup); + void parseProvenanceReportingYaml(YAML::Node *reportNode, + core::ProcessGroup * parentGroup); // Parse Properties Node YAML for a processor void parsePropertiesNodeYaml(YAML::Node *propertiesNode, std::shared_ptr<core::Processor> processor); + // Helper function to get or generate a component's id field --- End diff -- Can you use a more verbose comment block here? We're moving away from single line comments here. JavaDoc is better and will have a more positive impact when we generate docs than these single line function comments. Thanks! > Configuration without IDs for components causes exceptions > ---------------------------------------------------------- > > Key: MINIFI-275 > URL: https://issues.apache.org/jira/browse/MINIFI-275 > Project: Apache NiFi MiNiFi > Issue Type: Bug > Components: C++, Processing Configuration > Reporter: Aldrin Piri > Assignee: Kevin Doran > Priority: Blocker > Fix For: cpp-0.2.0 > > Attachments: config.TEST.yml > > > One of the changes to how components are handled in C++ introduced a defect > into the original construct over the version 1 schema of the YAML. > The absence of this ID causes a YAML exception. > We should provide handling to support configurations how they were created > originally, possibly providing a default/generated ID where one isn't > specified, and start laying the foundation for versioned schemas as provided > in our Java implementation. -- This message was sent by Atlassian JIRA (v6.3.15#6346)