[ https://issues.apache.org/jira/browse/MINIFI-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993169#comment-15993169 ]
ASF GitHub Bot commented on MINIFI-275: --------------------------------------- Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/85#discussion_r114137427 --- Diff: libminifi/src/core/yaml/YamlConfiguration.cpp --- @@ -538,14 +561,62 @@ void YamlConfiguration::parsePropertiesNodeYaml( std::string rawValueString = propertyValueNode.as<std::string>(); if (!processor->setProperty(propertyName, rawValueString)) { logger_->log_warn( - "Received property %s with value %s but is not one of the properties for %s", - propertyName.c_str(), rawValueString.c_str(), - processor->getName().c_str()); + "Received property %s with value %s but it is not one of the properties for %s", --- End diff -- is this with the formatter applied? > Configuration without IDs for components causes exceptions > ---------------------------------------------------------- > > Key: MINIFI-275 > URL: https://issues.apache.org/jira/browse/MINIFI-275 > Project: Apache NiFi MiNiFi > Issue Type: Bug > Components: C++, Processing Configuration > Reporter: Aldrin Piri > Assignee: Kevin Doran > Priority: Blocker > Fix For: cpp-0.2.0 > > Attachments: config.TEST.yml > > > One of the changes to how components are handled in C++ introduced a defect > into the original construct over the version 1 schema of the YAML. > The absence of this ID causes a YAML exception. > We should provide handling to support configurations how they were created > originally, possibly providing a default/generated ID where one isn't > specified, and start laying the foundation for versioned schemas as provided > in our Java implementation. -- This message was sent by Atlassian JIRA (v6.3.15#6346)