tmedicci commented on PR #11428: URL: https://github.com/apache/nuttx/pull/11428#issuecomment-1868540728
> > > > but, it's good to use the vendor hal file directly > > > > > > > > > I'm sorry, I didn't understand what you meant. Could you please elaborate a little further? > > > > > > All upstream code never calls vendor HAL directly, only download and link the static library. > > Oh, I see... this PR isn't about the "HAL", it's about the implementation of a common driver that is valid for all Espressif's xtensa-based devices. The same "common driver" approach is true for RISC-V-based devices, like [ESP32-C3](https://github.com/apache/nuttx/blob/master/arch/risc-v/src/espressif/hal_esp32c3.mk), [ESP32-C6](https://github.com/apache/nuttx/blob/master/arch/risc-v/src/espressif/hal_esp32c6.mk), [ESP32-H2](https://github.com/apache/nuttx/blob/master/arch/risc-v/src/espressif/hal_esp32h2.mk), for instance. > > Espressif is making a huge effort to avoid using closed static libraries: we plan to provide as much as possible the sources. Specifically for NuttX, we are just using header files and building specific auxiliary functions. There is no direct usage of "Espressif's HAL" on NuttX. Drivers' code and HAL-adapters are implemented on NuttX. Please note that the same is valid for the [Wireless driver of xtensa-based SoCs](https://github.com/apache/nuttx/blob/master/arch/xtensa/src/esp32s3/Wireless.mk). Just to make sure: please note that there is no generic code. The repository being downloaded is dedicated to providing sources being used on [NuttX](https://github.com/espressif/esp-hal-3rdparty/tree/release/v5.1.c): Similar approach with other manufacturers' implementation: - https://github.com/apache/nuttx/blob/master/arch/arm/src/nrf52/CMakeLists.txt - https://github.com/apache/nuttx/blob/master/arch/arm/src/nrf52/CMakeLists.txt - https://github.com/apache/nuttx/blob/master/arch/arm/src/nrf91/CMakeLists.txt - https://github.com/apache/nuttx/blob/0eeca0f3751876fc090108d01156d0999dd02116/arch/risc-v/src/bl602/Make.defs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
