tmedicci commented on code in PR #11428: URL: https://github.com/apache/nuttx/pull/11428#discussion_r1435879241
########## drivers/leds/ws2812.c: ########## @@ -55,15 +55,7 @@ * Pre-processor Definitions ****************************************************************************/ -#ifdef WS2812_HAS_WHITE -# define WS2812_RW_PIXEL_SIZE 4 -#else -# define WS2812_RW_PIXEL_SIZE 3 -#endif - -#ifdef CONFIG_WS2812_NON_SPI_DRIVER - -#else /* CONFIG_WS2812_NON_SPI_DRIVER */ Review Comment: @acassis , just to make it clearer: the model is 24-bit, but this is handled by the lower-half driver. The way the upper-half driver works on NuttX, it uses 32-bit (a word) for both RGB and RGBW models. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
