anchao commented on code in PR #11788:
URL: https://github.com/apache/nuttx/pull/11788#discussion_r1503840343
##########
CMakeLists.txt:
##########
@@ -355,6 +355,14 @@ if(NOT EXISTS ${CMAKE_BINARY_DIR}/.config OR NOT
"${NUTTX_DEFCONFIG}" STREQUAL
${NUTTX_DEFCONFIG}
CACHE INTERNAL "Saved defconfig path" FORCE)
+ # update value of CONFIG_BASE_DEFCONFIG
+
+ execute_process(
+ COMMAND
+ sed -ie
Review Comment:
> @anchao thanks for pinpointing the cause of CI failure. I pushed an update
which works locally.
>
> Interestingly it seems that our CMake system has already been using tools
like `cat`, `sed`, `grep`, `sort`, `uniq` etc?
>
> On the other side, my attempt of `string(REGEX REPLACE)` here wasn'ts
successful and the CMake native approach looks so tedious compared with the
`sed` approach.
>
> Let's see how this update goes and if @xuxin930 has a better way.
In the current implementation, some GNU utils are indeed used in cmake, but
I have not found them outside the macro control of WIN32, so it is better not
to use GNU utils in a common code (without WIN32 scope), if some functions
cannot be satisfied by cmake , please using python to implement that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
