yf13 commented on code in PR #11788:
URL: https://github.com/apache/nuttx/pull/11788#discussion_r1503956456
##########
CMakeLists.txt:
##########
@@ -355,6 +355,14 @@ if(NOT EXISTS ${CMAKE_BINARY_DIR}/.config OR NOT
"${NUTTX_DEFCONFIG}" STREQUAL
${NUTTX_DEFCONFIG}
CACHE INTERNAL "Saved defconfig path" FORCE)
+ # update value of CONFIG_BASE_DEFCONFIG
+
+ execute_process(
+ COMMAND
+ sed -ie
Review Comment:
@xuxin930 thanks!
- did you mean that we shall use a `file(APPEND "#define ...")` operation in
`nuttx_mkconfig.cmake` file instead?
- Is dirty status monitoring done by comparing `.config` with
`.config.orig`? if they differ then add "-dirty" to CONFIG_BASE_DEFCONFIG macro?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
