anchao commented on code in PR #12884:
URL: https://github.com/apache/nuttx/pull/12884#discussion_r1713130954
##########
tools/incdir.c:
##########
@@ -352,7 +358,8 @@ int main(int argc, char **argv, char **envp)
wintool = true;
#endif
}
- else if (compiler == COMPILER_SDCC || compiler == COMPILER_TASKING)
+ else if (compiler == COMPILER_SDCC || compiler == COMPILER_TASKING
+ || compiler == COMPILER_GHS)
Review Comment:
```suggestion
else if (compiler == COMPILER_SDCC || compiler == COMPILER_TASKING ||
compiler == COMPILER_GHS)
```
##########
arch/arm/src/Makefile:
##########
@@ -133,7 +133,7 @@ else
endif
ARCHSCRIPT := $(call CONVERT_PATH,$(ARCHSCRIPT))
-LDFLAGS += $(addprefix $(SCRIPT_OPT),$(addsuffix .tmp,$(ARCHSCRIPT)))
$(EXTRALINKCMDS)
+LDFLAGS += $(SCRIPT_OPT) $(addsuffix .tmp,$(ARCHSCRIPT)) $(EXTRALINKCMDS)
Review Comment:
Why remove multiple LD linker script support?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
