extinguish commented on code in PR #12884: URL: https://github.com/apache/nuttx/pull/12884#discussion_r1730936335
########## arch/arm/src/armv7-m/Toolchain.defs: ########## @@ -30,27 +30,6 @@ ifeq ($(CONFIG_ARCH_CORTEXM4),y) endif else ifeq ($(CONFIG_ARCH_CORTEXM7),y) TOOLCHAIN_ARM7EM := y - ifeq ($(CONFIG_ARM_TOOLCHAIN_GHS),y) Review Comment: > what's the rule to split Toolchain.def? All arm arch has ToolchainArmclang.defs etc, or each arch(e.g. armv7-m) has ToolchainArmclang.defs? we need make a decision before making this big change, @anchao . So, I suggest moving the refactor to new pr. Ok, the refactor patch will be pushed in a new pull request after current request is merged, and the new pull request will be based on current pull request -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
