pkarashchenko commented on code in PR #12885: URL: https://github.com/apache/nuttx/pull/12885#discussion_r1722324053
########## include/nuttx/can.h: ########## @@ -326,7 +326,7 @@ struct can_frame uint8_t __pad; /* padding */ uint8_t __res0; /* reserved / padding */ uint8_t __res1; /* reserved / padding */ - uint8_t data[CAN_MAX_DLEN] aligned_data(8); Review Comment: I think this was needed as some underlying drivers expect data to be properly aligned, so upcasting to `uint32_t *` and `uint64_t *` will not lead to memfault. How did you verify that this does not break existing CAN drivers for supported devices? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
