pkarashchenko commented on code in PR #12885: URL: https://github.com/apache/nuttx/pull/12885#discussion_r1730446312
########## include/nuttx/can.h: ########## @@ -326,7 +326,7 @@ struct can_frame uint8_t __pad; /* padding */ uint8_t __res0; /* reserved / padding */ uint8_t __res1; /* reserved / padding */ - uint8_t data[CAN_MAX_DLEN] aligned_data(8); Review Comment: Seems like `data` is naturally 4 bytes aligned, so there should be no impact. `canid_t` is 4 bytes followed by 1 byte `can_dlc` and 3 bytes of padding. The issue would be only if underlying driver would have 64 bits data registers. Since we do not have such case currently we may keep things as is and solve issues when they will appear. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
