raiden00pl commented on code in PR #13127: URL: https://github.com/apache/nuttx/pull/13127#discussion_r1728767578
########## include/nuttx/can/can.h: ########## @@ -81,11 +85,18 @@ * The configured size is limited to 255 to fit into a uint8_t. */ -#if !defined(CONFIG_CAN_FIFOSIZE) -# define CONFIG_CAN_FIFOSIZE 8 -#elif CONFIG_CAN_FIFOSIZE > 255 -# undef CONFIG_CAN_FIFOSIZE -# define CONFIG_CAN_FIFOSIZE 255 +#if !defined(CONFIG_CAN_TXFIFOSIZE) +# define CONFIG_CAN_TXFIFOSIZE 8 +#elif CONFIG_CAN_TXFIFOSIZE > 255 +# undef CONFIG_CAN_TXFIFOSIZE Review Comment: should we print warning that XXFIFOSIZE is invalid ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
