pkarashchenko commented on code in PR #2522:
URL: https://github.com/apache/nuttx-apps/pull/2522#discussion_r1730034274
##########
nshlib/nsh_parse.c:
##########
@@ -441,97 +421,25 @@ static void nsh_alist_free(FAR struct nsh_vtbl_s *vtbl,
}
#endif
-/****************************************************************************
- * Name: nsh_releaseargs
- ****************************************************************************/
-
-#ifndef CONFIG_NSH_DISABLEBG
-static void nsh_releaseargs(struct cmdarg_s *arg)
-{
- FAR struct nsh_vtbl_s *vtbl = arg->vtbl;
- int i;
-
- /* If the output was redirected, then file descriptor should
- * be closed. The created task has its one, independent copy of
- * the file descriptor
- */
-
- if (vtbl->np.np_redir_out)
- {
- close(arg->fd_out);
- }
-
- /* Same for the input */
-
- if (vtbl->np.np_redir_in)
- {
- close(arg->fd_in);
- }
-
- /* Released the cloned vtbl instance */
-
- nsh_release(vtbl);
-
- /* Release the cloned args */
-
- for (i = 0; i < arg->argc; i++)
- {
- free(arg->argv[i]);
- }
-
- free(arg);
-}
-#endif
-
/****************************************************************************
* Name: nsh_child
****************************************************************************/
#ifndef CONFIG_NSH_DISABLEBG
-static pthread_addr_t nsh_child(pthread_addr_t arg)
+static CODE int nsh_child(int argc, FAR char *argv[])
Review Comment:
```suggestion
static int nsh_child(int argc, FAR char *argv[])
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
