xiaoxiang781216 commented on code in PR #2522: URL: https://github.com/apache/nuttx-apps/pull/2522#discussion_r1730400928
########## builtin/exec_builtin.c: ########## @@ -24,11 +24,11 @@ #include <nuttx/config.h> -#include <spawn.h> #include <fcntl.h> #include <errno.h> #include <debug.h> +#include "nshlib/nshlib.h" Review Comment: builtin apps couldn't depend on nshlib, but system already depends on shell since it launches nsh program internally, this behavior also explicitly specified in spec: https://pubs.opengroup.org/onlinepubs/009695399/functions/system.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
