GUIDINGLI opened a new pull request, #14039:
URL: https://github.com/apache/nuttx/pull/14039
## Summary
fs poll optimize:
fs: Set the poll return value according to the man manual
The man manual describes that poll only has EFAULT, EINTR, EINVAL, and
ENOMEM return values.
If a file returns an error, the POLLERR event should be set and OK
should be returned
https://man7.org/linux/man-pages/man2/poll.2.html
When using libuv to poll the socket, the socket poll returned an EBUSY
error, causing libuv to abort.
The expected logic should be to return OK, allowing libuv to notify the
event listener that the POLLERR event occurred.
fs/vfs: result_independent_of_operands
timeout is a type of int
in MSEC2TICK, timeout may be multiplied by USEC_PER_MSEC
and the result may be out of range of int
Besides, this will induce following ERROR while running simulator:
vfs/fs_poll.c:498:38: runtime error: signed integer overflow:
19768268 * 1000 cannot be represented in type 'int'
## Impact
FS poll
## Testing
sim & qemu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
