eren-terzioglu commented on code in PR #14068:
URL: https://github.com/apache/nuttx/pull/14068#discussion_r1796530372
##########
arch/risc-v/src/common/espressif/Make.defs:
##########
@@ -120,8 +120,8 @@ ifeq ($(CONFIG_ESP_WIRELESS),y)
ifeq ($(CONFIG_ESPRESSIF_WIFI),y)
CHIP_CSRCS += esp_wifi_init.c
CHIP_CSRCS += esp_wlan.c
- CHIP_CSRCS += esp_wifi_utils.c
endif
+ CHIP_CSRCS += esp_wifi_utils.c
Review Comment:
We are using that file just for one function instead of repeating code again
which is called `esp_wifi_to_errno`. I will have a look again but there won't
be a huge issue at least for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]