yamt commented on code in PR #14460: URL: https://github.com/apache/nuttx/pull/14460#discussion_r1814739925
########## include/sys/types.h: ########## @@ -251,10 +251,10 @@ typedef uint16_t sa_family_t; #ifdef CONFIG_SYSTEM_TIME64 typedef uint64_t clock_t; -typedef uint64_t time_t; /* Holds time in seconds */ +typedef int64_t time_t; /* Holds time in seconds */ #else typedef uint32_t clock_t; -typedef uint32_t time_t; /* Holds time in seconds */ +typedef int32_t time_t; /* Holds time in seconds */ Review Comment: this makes 32-bit time_t almost unusable. if we make this change, we should make a bold statement to users. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
