GUIDINGLI commented on PR #14460: URL: https://github.com/apache/nuttx/pull/14460#issuecomment-2456408093
> > Disadvantage: > > None. > > Are you kidding? **Please be mindful of your words.** > > This is putting a HUGE number of unknown projects at risk. You dont know which unknown projects are using unsigned 32 bits timestamps out there. This will be a major and dangerous regression for them. As I said in the mail list: You should find a better way to ‘ put things right once and for all ’, and not use the unsigned int to postpone the occurrence. > > This change requires these project to be EXTRA careful about how they handle time comparisons. Lots of bug are report on this, after the SUB they suppose result will be < 0, but compare failed caused by the time_t to unsigned. > > AT LEAST, please, add an explicit #warning "32 bit time_t is now signed" that triggers when CONFIG_SYSTEM_TIME64 is not defined. Pretty please. Accept this, added -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
