yamt commented on code in PR #14755:
URL: https://github.com/apache/nuttx/pull/14755#discussion_r1839770620
##########
sched/semaphore/sem_holder.c:
##########
@@ -880,7 +880,7 @@ void nxsem_canceled(FAR struct tcb_s *stcb, FAR sem_t *sem)
{
/* Check our assumptions */
- DEBUGASSERT(atomic_load(NXSEM_COUNT(sem)) <= 0);
+ DEBUGASSERT((int16_t)atomic_load(NXSEM_COUNT(sem)) <= 0);
Review Comment:
anyway, while it's fine to have a discussion about how it should be, the
breakage is too severe to leave during the discussion, IMO.
please fix it soon, either with this PR or by reverting the changes in
question.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
