yamt commented on code in PR #14755:
URL: https://github.com/apache/nuttx/pull/14755#discussion_r1839761542
##########
sched/semaphore/sem_holder.c:
##########
@@ -880,7 +880,7 @@ void nxsem_canceled(FAR struct tcb_s *stcb, FAR sem_t *sem)
{
/* Check our assumptions */
- DEBUGASSERT(atomic_load(NXSEM_COUNT(sem)) <= 0);
+ DEBUGASSERT((int16_t)atomic_load(NXSEM_COUNT(sem)) <= 0);
Review Comment:
IMO, we should not pretend to have generic selection.
it's simpler to use concrete-type apis like, say, nx_atomic_load_int16.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
