nuttxpr commented on PR #15081: URL: https://github.com/apache/nuttx/pull/15081#issuecomment-2527023913
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides a summary of the change and mentions testing, it lacks crucial details. Here's what's missing: * **Summary:** While the *what* is described, the *why* and *how* are missing. Why is fetching TCB info in percpu scratch registers better for performance? Explain the mechanism and the expected performance gains. Mention any related NuttX issues. * **Impact:** The impact section is overly simplistic. While it mentions RISC-V arch code, it doesn't explicitly answer the required questions. Each impact question (user, build, hardware, documentation, security, compatibility) needs a YES/NO answer followed by a description if YES. Even if the answer is NO, stating it explicitly is important for clarity. For example: * Impact on user: NO * Impact on build: NO * Impact on hardware: YES (Affects RISC-V architectures. No changes to existing boards or drivers, but modifies low-level architecture code.) * Impact on documentation: NO (or YES if documentation needs updating) * Impact on security: NO (or YES with explanation if applicable) * Impact on compatibility: NO (or YES with explanation if applicable) * **Testing:** "ostest" is insufficient. Provide details about the build host (OS, CPU, compiler) and the specific RISC-V target (simulator, board, configuration) used for testing. Crucially, the testing logs *before* and *after* the change are missing. These logs are essential to demonstrate the actual performance improvement and validate the change's effectiveness. If `ostest` was run before and after, include the relevant output. Even a simple timing comparison would be helpful. The PR needs to be significantly more detailed to be considered complete. Provide the missing information to ensure reviewers can properly assess the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
