pussuw commented on code in PR #15081: URL: https://github.com/apache/nuttx/pull/15081#discussion_r1877656173
########## arch/risc-v/include/arch.h: ########## @@ -108,6 +208,31 @@ typedef struct arch_addrenv_s arch_addrenv_t; #endif /* __ASSEMBLY__ */ #endif /* CONFIG_ARCH_ADDRENV */ +#ifndef __ASSEMBLY__ Review Comment: Remove this once line 208 is removed ########## arch/risc-v/include/arch.h: ########## @@ -108,6 +208,31 @@ typedef struct arch_addrenv_s arch_addrenv_t; #endif /* __ASSEMBLY__ */ #endif /* CONFIG_ARCH_ADDRENV */ +#ifndef __ASSEMBLY__ + +/* Per CPU save area. Access to this structure can be gained via the scratch + * ([m/s]scratch) register. Prior to this, every CPU that + * wishes to access this information must call riscv_percpu_add_hart() which + * will set up [m/s]scratch to point to the CPUs own area + */ + +union riscv_percpu_s Review Comment: I think this needs to be arch_percpu_s now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
