anchao commented on code in PR #15231:
URL: https://github.com/apache/nuttx/pull/15231#discussion_r1888293008
##########
arch/xtensa/src/esp32/esp32_rtc.c:
##########
@@ -2188,7 +2189,7 @@ int up_rtc_cancelalarm(enum alm_id_e alarmid)
if (cbinfo->ac_cb != NULL)
{
- flags = spin_lock_irqsave(NULL);
+ flags = spin_lock_irqsave(&g_rtc_lock);
Review Comment:
```suggestion
sched_lock();
flags = spin_lock_irqsave(&g_rtc_lock);
```
https://github.com/apache/nuttx/pull/15232 Could we merge similar commits
into one commit? This makes reviewing easier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
