hartmannathan commented on code in PR #15850:
URL: https://github.com/apache/nuttx/pull/15850#discussion_r1958337862
##########
arch/arm/src/samv7/Kconfig:
##########
@@ -887,28 +903,96 @@ config SAMV7_PWM0_PD9_POL
Fault input is by default active on high level. This config
inverts the logic and makes fault active on low level.
+config SAMV7_PWM0_PD9_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is
cleared
Review Comment:
Ditto:
```suggestion
This option ensures the fault input remains active until it is
cleared
```
##########
arch/arm/src/samv7/Kconfig:
##########
@@ -872,6 +880,14 @@ config SAMV7_PWM0_PD8_POL
Fault input is by default active on high level. This config
inverts the logic and makes fault active on low level.
+config SAMV7_PWM0_PD8_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is
cleared
Review Comment:
Ditto:
```suggestion
This option ensures the fault input remains active until it is
cleared
```
##########
arch/arm/src/samv7/Kconfig:
##########
@@ -887,28 +903,96 @@ config SAMV7_PWM0_PD9_POL
Fault input is by default active on high level. This config
inverts the logic and makes fault active on low level.
+config SAMV7_PWM0_PD9_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is
cleared
+ by the software. Otherwise, the fault is cleared once the fault
input
+ changes its polarity level back to normal state.
+
endif
config SAMV7_PWM0_PMC
bool "External fault input from PMC"
default n
+if SAMV7_PWM0_PMC
+
+config SAMV7_PWM0_PMC_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is
cleared
Review Comment:
Ditto:
```suggestion
This option ensures the fault input remains active until it is
cleared
```
##########
arch/arm/src/samv7/Kconfig:
##########
@@ -1148,30 +1248,97 @@ config SAMV7_PWM1_PA28_POL
Fault input is by default active on high level. This config
inverts the logic and makes fault active on low level.
+config SAMV7_PWM1_PA28_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is
cleared
+ by the software. Otherwise, the fault is cleared once the fault
input
+ changes its polarity level back to normal state.
+
endif
config SAMV7_PWM1_PMC
bool "External fault input from PMC"
default n
+if SAMV7_PWM1_PMC
+
+config SAMV7_PWM1_PMC_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is
cleared
+ by the software. Otherwise, the fault is cleared once the fault
input
+ changes its polarity level back to normal state.
+
+endif
+
config SAMV7_PWM1_AFEC0
bool "External fault input from AFEC0"
default n
+if SAMV7_PWM1_AFEC0
+
+config SAMV7_PWM1_AFEC0_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is
cleared
Review Comment:
Ditto:
```suggestion
This option ensures the fault input remains active until it is
cleared
```
##########
arch/arm/src/samv7/Kconfig:
##########
@@ -1148,30 +1248,97 @@ config SAMV7_PWM1_PA28_POL
Fault input is by default active on high level. This config
inverts the logic and makes fault active on low level.
+config SAMV7_PWM1_PA28_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is
cleared
+ by the software. Otherwise, the fault is cleared once the fault
input
+ changes its polarity level back to normal state.
+
endif
config SAMV7_PWM1_PMC
bool "External fault input from PMC"
default n
+if SAMV7_PWM1_PMC
+
+config SAMV7_PWM1_PMC_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is
cleared
+ by the software. Otherwise, the fault is cleared once the fault
input
+ changes its polarity level back to normal state.
+
+endif
+
config SAMV7_PWM1_AFEC0
bool "External fault input from AFEC0"
default n
+if SAMV7_PWM1_AFEC0
+
+config SAMV7_PWM1_AFEC0_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is
cleared
+ by the software. Otherwise, the fault is cleared once the fault
input
+ changes its polarity level back to normal state.
+
+endif
+
config SAMV7_PWM1_AFEC1
bool "External fault input from AFEC1"
default n
+if SAMV7_PWM1_AFEC1
+
+config SAMV7_PWM1_AFEC1_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is
cleared
Review Comment:
Ditto:
```suggestion
This option ensures the fault input remains active until it is
cleared
```
##########
arch/arm/src/samv7/Kconfig:
##########
@@ -1148,30 +1248,97 @@ config SAMV7_PWM1_PA28_POL
Fault input is by default active on high level. This config
inverts the logic and makes fault active on low level.
+config SAMV7_PWM1_PA28_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is
cleared
Review Comment:
Ditto:
```suggestion
This option ensures the fault input remains active until it is
cleared
```
##########
arch/arm/src/samv7/Kconfig:
##########
@@ -1148,30 +1248,97 @@ config SAMV7_PWM1_PA28_POL
Fault input is by default active on high level. This config
inverts the logic and makes fault active on low level.
+config SAMV7_PWM1_PA28_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is
cleared
+ by the software. Otherwise, the fault is cleared once the fault
input
+ changes its polarity level back to normal state.
+
endif
config SAMV7_PWM1_PMC
bool "External fault input from PMC"
default n
+if SAMV7_PWM1_PMC
+
+config SAMV7_PWM1_PMC_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is
cleared
Review Comment:
Ditto:
```suggestion
This option ensures the fault input remains active until it is
cleared
```
##########
arch/arm/src/samv7/Kconfig:
##########
@@ -887,28 +903,96 @@ config SAMV7_PWM0_PD9_POL
Fault input is by default active on high level. This config
inverts the logic and makes fault active on low level.
+config SAMV7_PWM0_PD9_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is
cleared
+ by the software. Otherwise, the fault is cleared once the fault
input
+ changes its polarity level back to normal state.
+
endif
config SAMV7_PWM0_PMC
bool "External fault input from PMC"
default n
+if SAMV7_PWM0_PMC
+
+config SAMV7_PWM0_PMC_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is
cleared
+ by the software. Otherwise, the fault is cleared once the fault
input
+ changes its polarity level back to normal state.
+
+endif
+
config SAMV7_PWM0_AFEC0
bool "External fault input from AFEC0"
default n
+if SAMV7_PWM0_AFEC0
+
+config SAMV7_PWM0_AFEC0_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is
cleared
+ by the software. Otherwise, the fault is cleared once the fault
input
+ changes its polarity level back to normal state.
+
+endif
+
config SAMV7_PWM0_AFEC1
bool "External fault input from AFEC1"
default n
+if SAMV7_PWM0_AFEC1
+
+config SAMV7_PWM0_AFEC1_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is
cleared
Review Comment:
Ditto:
```suggestion
This option ensures the fault input remains active until it is
cleared
```
##########
arch/arm/src/samv7/Kconfig:
##########
@@ -1148,30 +1248,97 @@ config SAMV7_PWM1_PA28_POL
Fault input is by default active on high level. This config
inverts the logic and makes fault active on low level.
+config SAMV7_PWM1_PA28_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is
cleared
+ by the software. Otherwise, the fault is cleared once the fault
input
+ changes its polarity level back to normal state.
+
endif
config SAMV7_PWM1_PMC
bool "External fault input from PMC"
default n
+if SAMV7_PWM1_PMC
+
+config SAMV7_PWM1_PMC_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is
cleared
+ by the software. Otherwise, the fault is cleared once the fault
input
+ changes its polarity level back to normal state.
+
+endif
+
config SAMV7_PWM1_AFEC0
bool "External fault input from AFEC0"
default n
+if SAMV7_PWM1_AFEC0
+
+config SAMV7_PWM1_AFEC0_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is
cleared
+ by the software. Otherwise, the fault is cleared once the fault
input
+ changes its polarity level back to normal state.
+
+endif
+
config SAMV7_PWM1_AFEC1
bool "External fault input from AFEC1"
default n
+if SAMV7_PWM1_AFEC1
+
+config SAMV7_PWM1_AFEC1_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is
cleared
+ by the software. Otherwise, the fault is cleared once the fault
input
+ changes its polarity level back to normal state.
+
+endif
+
config SAMV7_PWM1_ACC
bool "External fault input from ACC"
default n
+if SAMV7_PWM1_ACC
+
+config SAMV7_PWM1_ACC_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is
cleared
+ by the software. Otherwise, the fault is cleared once the fault
input
+ changes its polarity level back to normal state.
+
+endif
+
config SAMV7_PWM1_TIM0
bool "External fault input from Timer 0"
default n
-endmenu
+if SAMV7_PWM1_TIM0
+config SAMV7_PWM1_TIM0_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is
cleared
Review Comment:
Ditto:
```suggestion
This option ensures the fault input remains active until it is
cleared
```
##########
arch/arm/src/samv7/Kconfig:
##########
@@ -1118,6 +1202,14 @@ config SAMV7_PWM1_PA21_POL
Fault input is by default active on high level. This config
inverts the logic and makes fault active on low level.
+config SAMV7_PWM1_PA21_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is
cleared
Review Comment:
Ditto:
```suggestion
This option ensures the fault input remains active until it is
cleared
```
##########
arch/arm/src/samv7/Kconfig:
##########
@@ -887,28 +903,96 @@ config SAMV7_PWM0_PD9_POL
Fault input is by default active on high level. This config
inverts the logic and makes fault active on low level.
+config SAMV7_PWM0_PD9_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is
cleared
+ by the software. Otherwise, the fault is cleared once the fault
input
+ changes its polarity level back to normal state.
+
endif
config SAMV7_PWM0_PMC
bool "External fault input from PMC"
default n
+if SAMV7_PWM0_PMC
+
+config SAMV7_PWM0_PMC_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is
cleared
+ by the software. Otherwise, the fault is cleared once the fault
input
+ changes its polarity level back to normal state.
+
+endif
+
config SAMV7_PWM0_AFEC0
bool "External fault input from AFEC0"
default n
+if SAMV7_PWM0_AFEC0
+
+config SAMV7_PWM0_AFEC0_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is
cleared
+ by the software. Otherwise, the fault is cleared once the fault
input
+ changes its polarity level back to normal state.
+
+endif
+
config SAMV7_PWM0_AFEC1
bool "External fault input from AFEC1"
default n
+if SAMV7_PWM0_AFEC1
+
+config SAMV7_PWM0_AFEC1_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is
cleared
+ by the software. Otherwise, the fault is cleared once the fault
input
+ changes its polarity level back to normal state.
+
+endif
+
config SAMV7_PWM0_ACC
bool "External fault input from ACC"
default n
+if SAMV7_PWM0_ACC
+
+config SAMV7_PWM0_ACC_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is
cleared
Review Comment:
Ditto:
```suggestion
This option ensures the fault input remains active until it is
cleared
```
##########
arch/arm/src/samv7/Kconfig:
##########
@@ -887,28 +903,96 @@ config SAMV7_PWM0_PD9_POL
Fault input is by default active on high level. This config
inverts the logic and makes fault active on low level.
+config SAMV7_PWM0_PD9_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is
cleared
+ by the software. Otherwise, the fault is cleared once the fault
input
+ changes its polarity level back to normal state.
+
endif
config SAMV7_PWM0_PMC
bool "External fault input from PMC"
default n
+if SAMV7_PWM0_PMC
+
+config SAMV7_PWM0_PMC_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is
cleared
+ by the software. Otherwise, the fault is cleared once the fault
input
+ changes its polarity level back to normal state.
+
+endif
+
config SAMV7_PWM0_AFEC0
bool "External fault input from AFEC0"
default n
+if SAMV7_PWM0_AFEC0
+
+config SAMV7_PWM0_AFEC0_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is
cleared
Review Comment:
Ditto:
```suggestion
This option ensures the fault input remains active until it is
cleared
```
##########
arch/arm/src/samv7/Kconfig:
##########
@@ -857,6 +857,14 @@ config SAMV7_PWM0_PA9_POL
Fault input is by default active on high level. This config
inverts the logic and makes fault active on low level.
+config SAMV7_PWM0_PA9_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is
cleared
+ by the software. Otherwise, the fault is cleared once the fault
input
+ changes its polarity level back to normal state.
Review Comment:
At minimum (extraneous `s` in `options`):
```suggestion
This option ensures the fault input remains active until it is
cleared
```
Perhaps for clarity:
```suggestion
When this option is selected, the fault input remains active
until it
is cleared by the software. When this option is not selected,
the
fault is cleared once the fault input changes its polarity
level back
to normal state.
```
WDYT?
##########
arch/arm/src/samv7/Kconfig:
##########
@@ -1133,6 +1225,14 @@ config SAMV7_PWM1_PA26_POL
Fault input is by default active on high level. This config
inverts the logic and makes fault active on low level.
+config SAMV7_PWM1_PA26_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is
cleared
Review Comment:
Ditto:
```suggestion
This option ensures the fault input remains active until it is
cleared
```
##########
arch/arm/src/samv7/Kconfig:
##########
@@ -1148,30 +1248,97 @@ config SAMV7_PWM1_PA28_POL
Fault input is by default active on high level. This config
inverts the logic and makes fault active on low level.
+config SAMV7_PWM1_PA28_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is
cleared
+ by the software. Otherwise, the fault is cleared once the fault
input
+ changes its polarity level back to normal state.
+
endif
config SAMV7_PWM1_PMC
bool "External fault input from PMC"
default n
+if SAMV7_PWM1_PMC
+
+config SAMV7_PWM1_PMC_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is
cleared
+ by the software. Otherwise, the fault is cleared once the fault
input
+ changes its polarity level back to normal state.
+
+endif
+
config SAMV7_PWM1_AFEC0
bool "External fault input from AFEC0"
default n
+if SAMV7_PWM1_AFEC0
+
+config SAMV7_PWM1_AFEC0_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is
cleared
+ by the software. Otherwise, the fault is cleared once the fault
input
+ changes its polarity level back to normal state.
+
+endif
+
config SAMV7_PWM1_AFEC1
bool "External fault input from AFEC1"
default n
+if SAMV7_PWM1_AFEC1
+
+config SAMV7_PWM1_AFEC1_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is
cleared
+ by the software. Otherwise, the fault is cleared once the fault
input
+ changes its polarity level back to normal state.
+
+endif
+
config SAMV7_PWM1_ACC
bool "External fault input from ACC"
default n
+if SAMV7_PWM1_ACC
+
+config SAMV7_PWM1_ACC_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is
cleared
Review Comment:
Ditto:
```suggestion
This option ensures the fault input remains active until it is
cleared
```
##########
arch/arm/src/samv7/Kconfig:
##########
@@ -887,28 +903,96 @@ config SAMV7_PWM0_PD9_POL
Fault input is by default active on high level. This config
inverts the logic and makes fault active on low level.
+config SAMV7_PWM0_PD9_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is
cleared
+ by the software. Otherwise, the fault is cleared once the fault
input
+ changes its polarity level back to normal state.
+
endif
config SAMV7_PWM0_PMC
bool "External fault input from PMC"
default n
+if SAMV7_PWM0_PMC
+
+config SAMV7_PWM0_PMC_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is
cleared
+ by the software. Otherwise, the fault is cleared once the fault
input
+ changes its polarity level back to normal state.
+
+endif
+
config SAMV7_PWM0_AFEC0
bool "External fault input from AFEC0"
default n
+if SAMV7_PWM0_AFEC0
+
+config SAMV7_PWM0_AFEC0_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is
cleared
+ by the software. Otherwise, the fault is cleared once the fault
input
+ changes its polarity level back to normal state.
+
+endif
+
config SAMV7_PWM0_AFEC1
bool "External fault input from AFEC1"
default n
+if SAMV7_PWM0_AFEC1
+
+config SAMV7_PWM0_AFEC1_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is
cleared
+ by the software. Otherwise, the fault is cleared once the fault
input
+ changes its polarity level back to normal state.
+
+endif
+
config SAMV7_PWM0_ACC
bool "External fault input from ACC"
default n
+if SAMV7_PWM0_ACC
+
+config SAMV7_PWM0_ACC_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is
cleared
+ by the software. Otherwise, the fault is cleared once the fault
input
+ changes its polarity level back to normal state.
+
+endif
+
config SAMV7_PWM0_TIM0
bool "External fault input from Timer 0"
default n
+if SAMV7_PWM0_TIM0
+
+config SAMV7_PWM0_TIM0_LATCHED
+ bool "Latched fault"
+ default n
+ ---help---
+ This options ensures the fault input remains active until it is
cleared
Review Comment:
Ditto:
```suggestion
This option ensures the fault input remains active until it is
cleared
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
