no1wudi opened a new pull request, #15854:
URL: https://github.com/apache/nuttx/pull/15854
## Summary
- Replace version checking logic using pkg_resources and importlib with a
subprocess call to `esptool.py version`
- This change enhances compatibility with esptool installed via pipx and
simplifies the version retrieval process
## Impact
- No functional changes; the script continues to prompt for installation if
esptool is not found
- Increases maintainability by reducing dependency on Python version checks
## Testing
GitHub CI and local build:
```
Create version.h
CPP:
/home/huang/Work/spark/nuttx/arch/xtensa/src/chip/esp-hal-3rdparty/components/esp_rom/esp32s3/ld/esp32s3.rom.api.ld->
/home/huang/Work/spark/nuttx/arch/xtensa/src/chip/esp-hal-3rdparty/components/esp_rom/espCPP:
/home/huang/Work/spark/nuttx/arch/xtensa/src/chip/esp-hal-3rdparty/components/esp_rom/esp32s3/ld/esp32s3.rom.ld->
/home/huang/Work/spark/nuttx/arch/xtensa/src/chip/esp-hal-3rdparty/components/esp_rom/esp32s3CPP:
/home/huang/Work/spark/nuttx/arch/xtensa/src/chip/esp-hal-3rdparty/components/esp_rom/esp32s3/ld/esp32s3.rom.newlib.ld->
/home/huang/Work/spark/nuttx/arch/xtensa/src/chip/esp-hal-3rdparty/components/esp_rom/CPP:
/home/huang/Work/spark/nuttx/arch/xtensa/src/chip/esp-hal-3rdparty/components/esp_rom/esp32s3/ld/esp32s3.rom.libgcc.ld->
/home/huang/Work/spark/nuttx/arch/xtensa/src/chip/esp-hal-3rdparty/components/esp_rom/CPP:
/home/huang/Work/spark/nuttx/arch/xtensa/src/chip/esp-hal-3rdparty/components/esp_rom/esp32s3/ld/esp32s3.rom.version.ld->
/home/huang/Wor
k/spark/nuttx/arch/xtensa/src/chip/esp-hal-3rdparty/components/esp_romCPP:
/home/huang/Work/spark/nuttx/arch/xtensa/src/chip/esp-hal-3rdparty/components/soc/esp32s3/ld/esp32s3.peripherals.ld->
/home/huang/Work/spark/nuttx/arch/xtensa/src/chip/esp-hal-3rdparty/components/soc/esp32s3LD:
nuttx
Memory region Used Size Region Size %age Used
ROM: 418660 B 16777184 B 2.50%
iram0_0_seg: 25344 B 304 KB 8.14%
irom0_0_seg: 484196 B 16777184 B 2.89%
dram0_0_seg: 95684 B 288 KB 32.44%
drom0_0_seg: 106916 B 16777184 B 0.64%
rtc_iram_seg: 0 B 8168 B 0.00%
rtc_data_seg: 0 B 8168 B 0.00%
rtc_reserved_seg: 0 B 24 B 0.00%
rtc_slow_seg: 0 B 8 KB 0.00%
MKIMAGE: ESP32-S3 binary
esptool.py -c esp32s3 elf2image --ram-only-header -fs 16MB -fm dio -ff 80m
-o nuttx.bin nuttx
esptool.py v4.8.1
Creating esp32s3 image...
Image has only RAM segments visible. ROM segments are hidden and SHA256
digest is not appended.
Merged 1 ELF section
Successfully created esp32s3 image.
Generated: nuttx.bin
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
