fdcavalcanti commented on code in PR #15854:
URL: https://github.com/apache/nuttx/pull/15854#discussion_r1960134390
##########
tools/espressif/check_esptool.py:
##########
@@ -92,4 +78,4 @@ def check_version(min_esptool_version: str) -> int:
if __name__ == "__main__":
parser = parser.parse_args()
- sys.exit(check_version(parser.version))
+ sys.exit(1 if check_version(parser.version) else 0)
Review Comment:
Why?
We only care if `sys.exit` is non-zero. Besides, check_version already
returns boolean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
