nuttxpr commented on PR #16310:
URL: https://github.com/apache/nuttx/pull/16310#issuecomment-2848886541

   [**\[Experimental Bot, please feedback 
here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
   
   __Fill In The Commit Message:__ This PR contains a Commit with an Empty 
Commit Message. Please fill in the Commit Message with the PR Summary.
   
   
   
   No, this PR does not fully meet the NuttX requirements. While the summary 
and impact sections are reasonably complete, the testing section is 
insufficient.  The statement "I did not test anything here" is unacceptable for 
a PR.  Even for trivial changes, some basic testing is required to demonstrate 
that the changes have the intended effect and don't introduce regressions.
   
   Here's a breakdown of what's missing and how to fix it:
   
   * **Testing:**  The author needs to provide *some* testing evidence. Since 
these are spelling corrections, the testing might involve:
       * **Compilation:**  Demonstrate that the code now compiles without the 
previous error.  Show the relevant compiler output before and after the change.
       * **Runtime Test (if applicable):** For the `udhcpc` log message and 
`nl_langinfo` changes, demonstrate the corrected output.  Even a simple test 
case showing the output before and after the change would suffice.  For the 
kinetis define, explain how its correctness was verified (e.g., inspection, 
successful compilation of dependent code).
   
   * **Target(s) and Build Host(s):**  Specify the development environment and 
target platform used (even if it's just a simulator).  This information is 
crucial for reproducibility.
   
   * **Testing Logs:**  Even if the tests are simple, include the actual output 
(e.g., compiler messages, log snippets) before and after the change.  Don't 
just describe the expected behavior.
   
   
   **Example of improved Testing Section:**
   
   ```
   ## Testing
   
   I confirm that changes are verified on local setup and works as intended:
   
   * Build Host(s):  macOS Ventura, Apple M1, GCC 12.2
   * Target(s):  sim:nsh
   
   **Compile Error Fix:**
   
   Testing logs before change (showed compiler error related to the misspelled 
identifier):
   
   ```
   path/to/file.c:123: error: ‘mispelled_identifer’ undeclared
   ```
   
   Testing logs after change (successful compilation):
   
   ```
   (no errors)
   ```
   
   **udhcpc Log Message:**
   
   Testing logs before change (missing interface name):
   
   ```
   udhcpc: started
   udhcpc: lease obtained
   ```
   
   Testing logs after change (interface name included):
   
   ```
   udhcpc: started on eth0
   udhcpc: lease obtained
   ```
   
   **nl_langinfo ("February") Fix:**
   
   Testing logs before change (misspelled month):
   
   ```
   Feburary
   ```
   
   Testing logs after change (correct spelling):
   
   ```
   February
   ```
   
   **Kinetis Define Fix:**
   
   The correctness of the KINETIS define was verified by inspection and 
confirmed by the successful compilation of the dependent driver code.
   ```
   
   By providing concrete evidence, the author can significantly strengthen the 
PR and make it easier for reviewers to assess the changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to