hartmannathan commented on PR #16310: URL: https://github.com/apache/nuttx/pull/16310#issuecomment-2849725894
> > As these affect totally separate and unrelated parts of the codebase, it makes sense to keep the four commits separate. > > > > Do I need to do anything about this? Or was it just a hint for the person choosing the appropriate merge action? Nothing to do here, it was just a hint for merging. > > (Only one minor nit: In the Kinetis commit, the commit log mentions a malformed define; it's not the define, but rather just the comment that is misspelled.) > > > > I really appreciate your care for proper wording! (I share this taste) > > But I think, in this case it is really the `define`, that is malformed, since the lack of comment tags turns the `define` into a compile-breaking mess: Ah yes, you are right!! I somehow missed that before. Good catch! > ```diff > > -# define KINETIS_NUART 6 /* Six UART modues */ > > -# define KINETIS_NSPI 3 Three SPI modules > > +# define KINETIS_NUART 6 /* Six UART modules */ > > +# define KINETIS_NSPI 3 /* Three SPI modules */ > > ``` > > > > (`KINETIS_NSPI` was broken; `KINETIS_NUART` just had a misspelled comment) > > > > > As a side note, I wonder if codespell can be one of our nightly tests. > > > > I think, this will be possible soon: I already prepared three more PRs (waiting for #16302 to be merged). Afterwards the number of misspellings should be down to around 100 lines of code spread over 28 files. Thanks again! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
