nuttxpr commented on PR #16318: URL: https://github.com/apache/nuttx/pull/16318#issuecomment-2851468744
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) __Fill In The Commit Message:__ This PR contains a Commit with an Empty Commit Message. Please fill in the Commit Message with the PR Summary. No. The PR description lacks crucial information required by the NuttX guidelines. Specifically: * **Summary:** While it mentions the changes, it lacks a clear explanation of *how* the changes work (e.g., "Corrected misspelled words X, Y, and Z in files A, B, and C using codespell."). Referencing other PRs is helpful context, but insufficient. * **Impact:** While mentioning reduced typos is good, it's too general. The template asks for specific impacts on users, build, hardware, documentation, security, and compatibility. Even if the answer is "NO" for most, it needs to be explicitly stated. For documentation, a "YES" is appropriate here, with a description like "Improved clarity and correctness of the documentation." * **Testing:** "Tested on myself" is not sufficient. The template requires details about the build host and target(s) used for testing, as well as testing logs *before* and *after* the changes. While readability is subjective, providing examples of corrected typos in the logs would significantly strengthen the testing section. Even if the change is purely documentation, build verification on relevant platforms should be included. In short, the PR needs to be more thorough and explicitly address each point in the template, even if the answer is a simple "NO." -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
