sumpfralle commented on PR #16318:
URL: https://github.com/apache/nuttx/pull/16318#issuecomment-2854536217
I am trying to summarize the state of discussion:
* A) Enabling codespell checks in `checkpatch.sh` by default?
* At the moment, *no tests* are enabled by default in that script. Maybe
we want to change this in a separate PR.
* This PR does not do anything in this field.
* See #16302 for codespell/CI-related recent changes.
* B) Should spelling mistakes in release notes be fixed?
* The release notes are automatically created based on commit titles.
* See the [(short) discussion in another
PR](https://github.com/apache/nuttx/pull/16282#discussion_r2065314637).
* This PR fixes spelling issues in release notes (i.e. release notes are
treated as "mutable").
* C) Prolonging truncated lines in release notes in case of spelling issues?
* Some commit titles are too long. These are truncated, which may cause
the last word to be detected by `codespell` as a typo.
* We could either fix spelling (i.e. raise the character limit per line)
or we add this truncated line to the list of codespell exceptions
(`.codespell-ignore-lines`).
* In this PR I picked the latter approach ("exception instead of
prolonging").
Personally I do not have a strong opinion for any of the points above. Thus,
if there is a desire to change any of the points above, I will happily adjust
the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
