xiaoxiang781216 commented on code in PR #16194:
URL: https://github.com/apache/nuttx/pull/16194#discussion_r2076022628
##########
sched/semaphore/sem_post.c:
##########
@@ -116,7 +153,10 @@ int nxsem_post_slow(FAR sem_t *sem)
* initialized if the semaphore is to used for signaling purposes.
*/
- nxsem_release_holder(sem);
+ if (!mutex || blocking)
Review Comment:
```suggestion
if (!mutex)
```
##########
sched/semaphore/sem_wait.c:
##########
@@ -126,6 +171,13 @@ int nxsem_wait_slow(FAR sem_t *sem)
rtcb->waitobj = sem;
+ /* In case of a mutex, store the previous holder in the task's list */
+
+ if (mutex)
Review Comment:
let's remove ALL holder related function call in the mutex case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
