pussuw commented on code in PR #16344:
URL: https://github.com/apache/nuttx/pull/16344#discussion_r2081061861


##########
arch/arm/src/armv7-a/arm_addrenv_ustack.c:
##########
@@ -129,15 +129,14 @@
 
 int up_addrenv_ustackalloc(struct tcb_s *tcb, size_t stacksize)
 {
+  arch_addrenv_t *addrenv;
   int ret;
 
   binfo("tcb=%p stacksize=%lu\n", tcb, (unsigned long)stacksize);
 
   DEBUGASSERT(tcb);
 
-  /* Initialize the address environment list to all zeroes */
-
-  memset(tcb->xcp.ustack, 0, ARCH_STACK_NSECTS * sizeof(uintptr_t *));
+  addrenv = &tcb->group->tg_addrenv_own->addrenv;

Review Comment:
   There is no tg_addrenv_own in group



##########
arch/arm/src/armv7-a/arm_addrenv_ustack.c:
##########
@@ -178,15 +179,20 @@ int up_addrenv_ustackalloc(struct tcb_s *tcb, size_t 
stacksize)
 
 int up_addrenv_ustackfree(struct tcb_s *tcb)
 {
+  arch_addrenv_t *addrenv;
+
   binfo("tcb=%p\n", tcb);
   DEBUGASSERT(tcb);
 
+  addrenv = &tcb->group->tg_addrenv_own->addrenv;

Review Comment:
   Ditto



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to